CLI-1075 Rename connector cmds to connect and connector-catalog to connect plugin #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DABH
reviewed
Jul 28, 2021
brianstrauch
reviewed
Aug 3, 2021
|
changing the naming of |
MuweiHe
changed the title
DABH
approved these changes
Aug 11, 2021
Comment on lines
28
to
31
| var ( | ||
| catalogFields = []string{"PluginName", "Type"} | ||
| catalogStructureLabels = []string{"plugin_name", "type"} | ||
| pluginFields = []string{"PluginName", "Type"} | ||
| pluginStructureLabels = []string{"plugin_name", "type"} | ||
| ) |
There was a problem hiding this comment.
Unrelated, but we should get into the habit of placing these variables in the function they're being used in. That way, we can just call them fields or structureLabels and we won't have to change their name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
[CRUCIAL] Is the change for CP or CCloud functionalities that are already live in prod?
Did you add/update any commands that accept secrets as args/flags?
What
For CLI 2.0, we want to make a breaking change:
ccloud connector-catalogshould not be a top-level command. It naturally falls under the auspices of "Connect comamnds", so, we should rename this to e.g.ccloud connector catalogReferences
Test&Review