Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI Unification: Rename confluent signup to confluent cloud-signup #956

Merged
merged 4 commits into from
Aug 11, 2021

Conversation

brianstrauch
Copy link
Member

Checklist

  1. [CRUCIAL] Is the change for CP or CCloud functionalities that are already live in prod?

    • yes: ok
  2. Did you add/update any commands that accept secrets as args/flags?

    • no: ok

What

ccloud signup made sense, confluent signup does not. This PR renames that command to confluent cloud-signup. I've also changed the command to always be available since it doesn't require a login.

@brianstrauch brianstrauch requested a review from a team as a code owner August 2, 2021 23:07
Copy link
Contributor

@DABH DABH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems ok to me. cc @ethanruhe

@brianstrauch brianstrauch merged commit aee00f8 into main Aug 11, 2021
@brianstrauch brianstrauch deleted the cloud-signup branch August 11, 2021 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants