CLI-965 Remove broker information in ccloud kafka topic describe
#960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you write some tests for this? Looks like there are no integration tests 😢 |
I see a few |
brianstrauch
approved these changes
Aug 9, 2021
|
@MuweiHe This PR should target |
DABH
reviewed
Aug 10, 2021
|
Argh, this is kind of a nit, but it would be nice if we could separate this change from all the other changes that are in master but not in 2.0 yet. Is there any chance you could like rebase the changes you made on top of 2.0, and/or copy the master commits to 2.0 separately (preserving git history/authorship)? Happy to help if that proves to be a pain. |
DABH
approved these changes
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
[CRUCIAL] Is the change for CP or CCloud functionalities that are already live in prod?
Did you add/update any commands that accept secrets as args/flags?
What
ccloud kafka topic describeis listing broker information. It is exposing concepts (partitions, leaders, replicas, ISRs) that Cloud should abstract away. These should be removed.References
Test&Review