Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KCI-843 make api key and secret required when creating ksql #968

Merged
merged 3 commits into from
Aug 18, 2021

Conversation

lct45
Copy link
Contributor

@lct45 lct45 commented Aug 13, 2021

Per KCI-843 make api keys and secrets mandatory when creating a new ksqlDB app through the CLI as this is the new process.

Test&Review

updated existing unit + integration testing to reflex mandatory flags

@lct45
Copy link
Contributor Author

lct45 commented Aug 13, 2021

manual testing:

lthomas@Leah-Thomas-MBP16 confluent_cli % dist/ccloud/ccloud_$(go env GOOS)_$(go env GOARCH)/ccloud ksql app create leah_test
Error: required flag(s) "api-key", "api-secret" not set
Usage:
ccloud ksql app create [flags]

Flags:
--csu int32 Number of CSUs to use in the cluster. (default 4)
-o, --output string Specify the output format as "human", "json", or "yaml". (default "human")
--api-key string REQUIRED: Kafka API key for the ksqlDB cluster to use.
--api-secret string REQUIRED: Secret for the Kafka API key.
--environment string Environment ID.
--cluster string Kafka cluster ID.
--context string CLI context name.

Global Flags:
-h, --help Show help for this command.
-v, --verbose count Increase verbosity (-v for warn, -vv for info, -vvv for debug, -vvvv for trace).

lthomas@Leah-Thomas-MBP16 confluent_cli % dist/ccloud/ccloud_$(go env GOOS)_$(go env GOARCH)/ccloud ksql app create leah_test --api-key key --api-secret secret --cluster lkc-q0n3p
+--------------+----------------------------------------------------------+
| Id | lksqlc-v1ymyn |
| Name | leah_test |
| Topic Prefix | pksqlc-mo20q |
| Kafka | lkc-q0n3p |
| Storage | 500 |
| Endpoint | https://pksqlc-mo20q.us-west-2.aws.devel.cpdev.cloud:443 |
| Status | PROVISIONING |
+--------------+----------------------------------------------------------+

internal/cmd/ksql/command_test.go Outdated Show resolved Hide resolved
internal/cmd/ksql/command_test.go Outdated Show resolved Hide resolved
internal/cmd/ksql/command_cluster.go Outdated Show resolved Hide resolved
internal/cmd/ksql/command_cluster.go Outdated Show resolved Hide resolved
Co-authored-by: Brian Strauch <bstrauch24@gmail.com>
Copy link
Member

@brianstrauch brianstrauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lct45 lct45 merged commit f559235 into 2.0 Aug 18, 2021
@lct45 lct45 deleted the deprecate_ksql_api branch August 18, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants