Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-1107: Update confluent login environment variables #981

Merged
merged 5 commits into from
Sep 13, 2021

Conversation

brianstrauch
Copy link
Member

@brianstrauch brianstrauch commented Aug 27, 2021

Checklist

  1. [CRUCIAL] Is the change for CP or CCloud functionalities that are already live in prod?

    • yes: ok
  2. Did you add/update any commands that accept secrets as args/flags?

    • no: ok

What

Update the following environment variables:

  • CCLOUD_EMAIL → CONFLUENT_CLOUD_EMAIL
  • CCLOUD_PASSWORD → CONFLUENT_CLOUD_PASSWORD
  • CONFLUENT_USERNAME → CONFLUENT_PLATFORM_USERNAME
  • CONFLUENT_PASSWORD → CONFLUENT_PLATFORM_PASSWORD
  • CONFLUENT_MDS_URL → CONFLUENT_PLATFORM_MDS_URL
  • CONFLUENT_CA_CERT_PATH → CONFLUENT_PLATFORM_CA_CERT_PATH

References

CLI-1107

Test & Review

Test cases still pass. Manually verified that warnings are printed:

$ CCLOUD_EMAIL=bstrauch@confluent.io CCLOUD_PASSWORD=[REDACTED] confluent login
`CCLOUD_EMAIL` has been deprecated and replaced by `CONFLUENT_CLOUD_EMAIL`.
`CCLOUD_PASSWORD` has been deprecated and replaced by `CONFLUENT_CLOUD_PASSWORD`.
$ CONFLUENT_USERNAME=bstrauch@confluent.io CONFLUENT_PASSWORD=[REDACTED] CONFLUENT_MDS_URL=https://example.com:8090 CONFLUENT_CA_CERT_PATH=example.txt confluent login
`CONFLUENT_MDS_URL` has been deprecated and replaced by `CONFLUENT_PLATFORM_MDS_URL`.
`CONFLUENT_USERNAME` has been deprecated and replaced by `CONFLUENT_PLATFORM_USERNAME`.
`CONFLUENT_PASSWORD` has been deprecated and replaced by `CONFLUENT_PLATFORM_PASSWORD`.
`CONFLUENT_CA_CERT_PATH` has been deprecated and replaced by `CONFLUENT_PLATFORM_CA_CERT_PATH`.

@brianstrauch brianstrauch requested a review from a team as a code owner August 27, 2021 21:42
Copy link
Contributor

@MuweiHe MuweiHe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once ci passes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants