Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move dependency-check to only run under jenkins maven profile #182

Merged
merged 1 commit into from Mar 12, 2019
Merged

Move dependency-check to only run under jenkins maven profile #182

merged 1 commit into from Mar 12, 2019

Conversation

ewencp
Copy link
Contributor

@ewencp ewencp commented Mar 7, 2019

No description provided.

@ewencp ewencp requested a review from a team March 7, 2019 18:15
@ewencp
Copy link
Contributor Author

ewencp commented Mar 7, 2019

I would prefer to keep this in the main developer path, but atm there seems to be some issue with db locking in Jenkins jobs that access it repeatedly, e.g. ducker builds. Most developers will probably prefer this anyway since the scanning takes time and isn't important to their normal workflow. They can always still run this locally under the jenkins profile if needed.

@ewencp ewencp merged commit 2b30d58 into confluentinc:3.3.x Mar 12, 2019
@ewencp ewencp deleted the dependency-check-jenkins branch March 12, 2019 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxzheng maxzheng maxzheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ewencp @maxzheng