update various maven plugins #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- many plugins now require maven 3.x - many bugfixes and improvement for recent JDK versions - major version upgrades: * checkstyle plugin 3.1.1 * surefire plugin 3.0.0-M4 * spotbugs plugin 4.0.0 (spotbugs 4.0.2) * deploy plugin 3.0.0-M1 * intall plugin 3.0.0-M1 - remove deprecated checkstyle configs
What does this refer to? I don't see anything in the diff that suggests such a change? |
|
@ewencp I'm referring to this change https://github.com/confluentinc/common/pull/258/files#diff-600376dffeb79835ede4a0b285078036R412-R414, checkstyle deprecated the use of the top-level sourceDirectory tag |
ewencp
approved these changes
Apr 24, 2020
There was a problem hiding this comment.
looks like this is blocked by https://confluentinc.atlassian.net/browse/CC-8869 but generally looks good if we can clear out downstream errors and get a green build
gracechensd
added a commit
that referenced
this pull request
Jun 3, 2020
This reverts commit ec9af9e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
did spot-checks on a few downstream repos and didn't see issues, in no way exhaustive though.