Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downgrade maven-deploy-plugin to 2.8.2 #265

Merged
merged 1 commit into from Jun 5, 2020
Merged

Conversation

xvrl
Copy link
Member

@xvrl xvrl commented Jun 5, 2020

also downgrades intall plugin to 2.5.2 since 3.0.0-M1 of install
plugin requires 3.0.0-M1 of deploy plugin according to releaes notes
https://blogs.apache.org/maven/entry/apache-maven-install-plugin-version

This is required becauses some components in our build environment are
still relying on deploy plugin 2.7.x, which prevents us from switching
to the new 3.0.x syntax for alt*DeploymentRepository which requires
removing the 'layout' component of the repo.
see https://maven.apache.org/plugins/maven-deploy-plugin/deploy-mojo.html

@xvrl xvrl requested a review from ewencp June 5, 2020 05:38
* also downgrades intall plugin to 2.5.2 since 3.0.0-M1 of install
plugin requires 3.0.0-M1 of deploy plugin according to releaes notes
https://blogs.apache.org/maven/entry/apache-maven-install-plugin-version

This is required becauses some components in our build environment are
still relying on deploy plugin 2.7.x, which prevents us from switching
to the new 3.0.x syntax for alt*DeploymentRepository which requires
removing the 'layout' component of the repo.
see https://maven.apache.org/plugins/maven-deploy-plugin/deploy-mojo.html
Copy link
Contributor

@ewencp ewencp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting on green pr build, but otherwise lgtm

@xvrl
Copy link
Member Author

xvrl commented Jun 5, 2020

@ewencp also downgrading install plugin out of abundance of caution due to release notes of both plugins saying their 3.0.0-M1 versions should only be used together.

@xvrl
Copy link
Member Author

xvrl commented Jun 5, 2020

there are still unrelated downstream compilation errors that prevent us from testing any changes in this repo. cc @sdanduConf

[2020-06-05T06:10:45.658Z] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project kafka-connect-storage-core: Compilation failure [2020-06-05T06:10:45.658Z] [ERROR] /home/jenkins/workspace/confluentinc-pr_common_PR-265/kafka-connect-storage-common-master/core/src/main/java/io/confluent/connect/storage/StorageSinkTestBase.java:[186,20] io.confluent.connect.storage.StorageSinkTestBase.MockSinkTaskContext is not abstract and does not override abstract method errantRecordReporter() in org.apache.kafka.connect.sink.SinkTaskContext

@sdandu-gh sdandu-gh merged commit 8430fdf into master Jun 5, 2020
xvrl added a commit that referenced this pull request Jun 5, 2020
@xvrl xvrl deleted the downgrade-maven-deploy branch February 16, 2022 21:47
xvrl added a commit that referenced this pull request Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants