Use schema ID returned from GetID() (fixes #848) #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
perdue
force-pushed
the
pr/fix_issue_848
branch
from
7ae855c
to
e714a40
Compare
|
This looks good to me, but I'll let @rayokota chime in as well. It would be good with a test for this case. |
edenhill
approved these changes
Oct 11, 2022
rayokota
approved these changes
Oct 11, 2022
|
Thank you! |
PrasanthV454
pushed a commit
that referenced
this pull request
Jan 12, 2023
PrasanthV454
pushed a commit
that referenced
this pull request
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.