Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]implemented incremental alter configs (KIP-339) #945

Merged
merged 16 commits into from
Jul 11, 2023

Conversation

PrasanthV454
Copy link
Member

PR for KIP-339 implementation. With this PR new AlterOperations are introduced ->

  1. Append
  2. Subtract
  3. Remove

There is no necessity in passing all config values for changing certain configs.
Support for list type Config Values is also added.

Copy link
Contributor

@milindl milindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes only

kafka/adminapi.go Outdated Show resolved Hide resolved
kafka/adminapi.go Outdated Show resolved Hide resolved
kafka/adminapi.go Outdated Show resolved Hide resolved
kafka/adminapi.go Outdated Show resolved Hide resolved
kafka/integration_test.go Show resolved Hide resolved
kafka/config.go Show resolved Hide resolved
kafka/config.go Show resolved Hide resolved
@milindl
Copy link
Contributor

milindl commented Jul 4, 2023

LGTM, can merge after librdkafka (CI will not pass until then)

@milindl milindl merged commit 9fbcafc into master Jul 11, 2023
2 checks passed
@milindl milindl deleted the feature/incremental-alter branch July 11, 2023 05:18
chang-you pushed a commit that referenced this pull request Aug 14, 2023
---------

Co-authored-by: Emanuele Sabellico <esabellico@confluent.io>
Co-authored-by: Milind L <milindl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants