Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning: "Please migrate your Python Protobuf producers and consumers to 'use.deprecated.format':True" #1265

Closed
martinskeem opened this issue Jan 13, 2022 · 3 comments
Labels

Comments

@martinskeem
Copy link

martinskeem commented Jan 13, 2022

This warning does not make much sense to me:

"Please migrate your Python Protobuf producers and "
"consumers to 'use.deprecated.format':True as "
"soon as possible")

  • Should a warning really be emitted if 'use.deprecated.format': False? I would have thought that the warning was emitted only if using the deprecated format.

  • Should the warning state "... migrate ... producers and consumers to 'use.deprecated.format':True"? I would have thought that producers and consumers should migrate to the format which is not deprecated

@edenhill
Copy link
Contributor

Ugh, that's embarrassing. This is what happens with double negations..

@Derfirm
Copy link

Derfirm commented Mar 4, 2022

Hello!
Any update on this issue?
Are you planning make release with this fix?
Thx.

@jliunyu
Copy link
Contributor

jliunyu commented Apr 8, 2022

Hello! Any update on this issue? Are you planning make release with this fix? Thx.

The fix is merged and will be released with v1.9.0.

@jliunyu jliunyu closed this as completed Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants