Enhance serializers with use.latest.version config #1133
Conversation
|
@confluentinc It looks like @rayokota just signed our Contributor License Agreement. 👍 Always at your service, clabot |
Also add additional checks that both use.latest.version and auto.register.schemas are not set
| .format(subject), 0) | ||
| assert register_count == 0 | ||
| # Ensure latest was requested | ||
| assert test_client.counter['GET'].get('/subjects/{}/versions/latest'.format(subject)) == 1 |
There was a problem hiding this comment.
there should really be more test coverage of this stuff.
but i'm ok with the effort/benefit tradeoff.
|
Fixes bug where a schema lookup is performed for every ProtobufSerializer call. Made Protobuf and schema registry impractical to use for anything but the smallest producers as it would make the lookup, on my network this would take 0.2 seconds per produce. Adds up quick. |
|
@Atheuz - to clarify - are you saying this PR fixed such a bug, or the bug remains in 1.8.2? |
|
@mhowlett this PR fixed the bug and as such is fixed in the 1.8.2 release. It just wasn't stated anywhere here, so I wanted to add a comment. |
Also add skip.known.types config for Protobuf serializer