Add metadata to TopicPartition #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A Kafka offset commit message includes optional metadata, but python client doesn't support it yet.
|
|
milindl
commented
Aug 22, 2022
milindl
commented
Aug 22, 2022
milindl
commented
Aug 22, 2022
milindl
commented
Aug 22, 2022
milindl
commented
Aug 22, 2022
milindl
commented
Aug 22, 2022
milindl
force-pushed
the
feature/topicpartition_to_have_metdata
branch
from
eab29a1
to
1eda4f0
Compare
|
Updated PR to use strings as the metadata type. Reading with "s" ensures that we get a utf-8 encoded version of the unicode object or string, as well as an error for a NULL character in the middle of the string, which is what we want. |
edenhill
suggested changes
Oct 10, 2022
tests/integration/consumer/test_consumer_topicpartition_metadata.py
Outdated
Show resolved
Hide resolved
This was referenced Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #1126 (retains commit history).
Since there are comments on the prior PR, I'll both add those comments here and address them here.