Implemented KIP-88, KIP-222, KIP-518 and partially KIP-396 #1449

pranavrth · 2022-10-18T02:23:38Z

Implemented the following admin operations:

List Consumer Groups
Describe Consumer Groups
Delete Consumer Groups
List Consumer Group Offsets
Alter Consumer Group Offsets

…y file

examples/adminapi.py

…ations.

…rs from consumer group listing and description

use ValidationUtil and ConversionUtil

…GELOG statements

src/confluent_kafka/_model/__init__.py

src/confluent_kafka/admin/__init__.py

…e consumer groups operations

…oup_id, future]

…ckground callbacks of some admin operations and initialized some of the uninitialzed variables

in ListConsumerGroupOffsets

emasab

Great job Pranav!

…1449) Implement KIP-88, KIP-222, KIP-229, KIP-518 and partially KIP-396 (#3995) Add support for: KIP-88, KIP-222: ListConsumerGroups, DescribeConsumerGroups, ListConsumerGroupOffsets, KIP-229: DeleteConsumerGroups, KIP-396: AlterConsumerGroupOffsets, KIP-518. Co-authored-by: Emanuele Sabellico <esabellico@confluent.io>

pranavrth added 15 commits September 26, 2022 12:13

Alter and List consumer group operations

2ea142a

Added require_stable option in ListConsumerGroupOffsets API

c344023

Added Integration test

f8727fc

Temp Commit

7f71ac8

Fixed integration test to work without sleep

d3bd645

Fixed unused import issue

926c6ad

Formatting fixes

3c96288

Changed import from ..cimpl instead of confluent_kafka for _offsets.p…

0b6bd99

…y file

Removed list and describe consumer group new implementations

3aa56f6

After adding list group in examples

96faf14

Added usage for the delete consumer groups operation in example

4ee6878

Added test cases for delete operation

e001267

Removed unnecessary changes

73f84b6

Doc and return type changes

6877a32

Updated Vairable names

b75253c

mhowlett reviewed Oct 27, 2022

View reviewed changes

examples/adminapi.py Outdated Show resolved Hide resolved

mhowlett reviewed Oct 27, 2022

View reviewed changes

examples/adminapi.py Show resolved Hide resolved

pranavrth added 4 commits December 12, 2022 17:34

Working list consumer groups

855e1f4

Added describe and list consumer groups

7ddc119

Some improvement to the code

de2b691

Removed some TODOs

292f3c7

pranavrth changed the title ~~List and Alter Consumer Group offsets and Delete Consumer Groups~~ Implemented KIP-88, KIP-222, KIP-518 and partially KIP-396 Dec 27, 2022

pranavrth added 8 commits December 29, 2022 05:21

Moved validations for alter and list offsets API to validation util

fccbbff

Added an integration test

d64d71f

Refactoring

1fe9018

Flake8 fixes

d2df7c5

Added integration test for describe consumer groups. Added more valid…

3799fac

…ations.

Fixing a memory leak

4dbced1

Removed validations from the response. Improved example. Removed erro…

291b73a

…rs from consumer group listing and description

Add doc TODO

a8ebaa5

pranavrth mentioned this pull request Jan 12, 2023

Missing ListConsumerGroupOffsets equiv in AdminClient #1497

Closed

pranavrth and others added 5 commits January 12, 2023 17:22

PR comments

4c45bf1

Added docs and Changelog

0de8f4c

Changelog fixes

7d63d2b

Make util and model packages private,

bea1567

use ValidationUtil and ConversionUtil

Added few changes related to ordering of the functions, docs and CHAN…

2aa361c

…GELOG statements

pranavrth commented Jan 13, 2023

View reviewed changes

src/confluent_kafka/_model/__init__.py Show resolved Hide resolved

src/confluent_kafka/admin/__init__.py Outdated Show resolved Hide resolved

src/confluent_kafka/admin/__init__.py Show resolved Hide resolved

Added old change to CHANGELOG

aff12ac

emasab force-pushed the list-alter-cg-offset-delete-cg branch from 139ce2c to 34f2b82 Compare January 13, 2023 07:51

Internal TopicPartition in admin

3d4dcb0

emasab force-pushed the list-alter-cg-offset-delete-cg branch from 34f2b82 to 3d4dcb0 Compare January 13, 2023 08:00

emasab reviewed Jan 13, 2023

View reviewed changes

src/confluent_kafka/admin/__init__.py Outdated Show resolved Hide resolved

pranavrth and others added 11 commits January 13, 2023 15:53

Moved ConsumerGroupState to confluent_kafka instead of admin

92905de

Changed return type of delete consumer groups request to None

ba1937b

Using request_timeout instead of timeout for list, describe and delet…

0ea2524

…e consumer groups operations

changed return type of list and alter cg offsets operation to dict[gr…

bde5af5

…oup_id, future]

PEP8 fixes

91fda73

Changed states filter type from list to set

b768037

Updated librdkafka version

9b61d89

Updated librdkafka version for travis job

3348fcd

Fixed docstring test failure for ConsumerGroupState

7d37cb8

Some refactoring

ff23afb

Fix error strings

7beaf79

emasab force-pushed the list-alter-cg-offset-delete-cg branch from 34598e5 to 7beaf79 Compare January 16, 2023 16:11

pranavrth and others added 2 commits January 16, 2023 23:23

Refactored function names, removed unnecessary error handling from ba…

7cefc27

…ckground callbacks of some admin operations and initialized some of the uninitialzed variables

Fix test error caused by ACLs

67d6d59

in ListConsumerGroupOffsets

emasab approved these changes Jan 16, 2023

View reviewed changes

pranavrth merged commit 1db3054 into master Jan 16, 2023

pranavrth deleted the list-alter-cg-offset-delete-cg branch January 16, 2023 20:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implemented KIP-88, KIP-222, KIP-518 and partially KIP-396 #1449

Implemented KIP-88, KIP-222, KIP-518 and partially KIP-396 #1449

pranavrth commented Oct 18, 2022 •

edited

emasab left a comment

Implemented KIP-88, KIP-222, KIP-518 and partially KIP-396 #1449

Implemented KIP-88, KIP-222, KIP-518 and partially KIP-396 #1449

Conversation

pranavrth commented Oct 18, 2022 • edited

emasab left a comment

Choose a reason for hiding this comment

pranavrth commented Oct 18, 2022 •

edited