Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linux ARM64 wheels block in Semaphore #1496

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

anchitj
Copy link
Member

@anchitj anchitj commented Jan 10, 2023

Added block in semaphore to build wheels for Linux Arm64.

cibuildwheel isn't working, as the wheel generated from it weren't installable. So generating the wheels thorugh recompiling librdkafka and using the manual wheel building script.

@pranavrth
Copy link
Member

We want to generate Linux arm64 wheels. x64 wheels generation is already present in Travis job for now.

@anchitj
Copy link
Member Author

anchitj commented Jan 10, 2023

We want to generate Linux arm64 wheels. x64 wheels generation is already present in Travis job for now.

Yeah, I'm right now testing the x64 itself through this draft PR as it's failing. Will update the PR to in review state once it's ready.

@anchitj anchitj changed the title Add linux x64 wheel script [WIP]Add linux x64 wheel script Jan 10, 2023
@pranavrth
Copy link
Member

We want to generate Linux arm64 wheels. x64 wheels generation is already present in Travis job for now.

Yeah, I'm right now testing the x64 itself through this draft PR as it's failing. Will update the PR to in review state once it's ready.

Oh. I thought you got confused b/w x64 and arm64. Carry on.

@anchitj anchitj force-pushed the anchit/SemaphoreLinuxWheels branch 24 times, most recently from 7dc3a94 to 52b55d1 Compare January 16, 2023 11:31
@emasab
Copy link
Contributor

emasab commented Feb 2, 2023

@anchitj yes, please add a changelog entry because it's something that simplifies the client's installation

@anchitj anchitj force-pushed the anchit/SemaphoreLinuxWheels branch 11 times, most recently from 744d37b to a73f93c Compare February 2, 2023 18:05
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@emasab emasab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run only on tags there

.semaphore/semaphore.yml Show resolved Hide resolved
tools/bootstrap-librdkafka.sh Outdated Show resolved Hide resolved
@anchitj anchitj force-pushed the anchit/SemaphoreLinuxWheels branch 2 times, most recently from 9ad1775 to b389355 Compare February 3, 2023 16:48
Copy link
Contributor

@emasab emasab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Anchit! I've verified the wheel on Linux / arm64 too and it works correctly, with SSL too.

@anchitj anchitj merged commit 6a3f438 into master Feb 6, 2023
@anchitj anchitj deleted the anchit/SemaphoreLinuxWheels branch February 6, 2023 11:42
@mauriciogardini
Copy link

Hello, sorry to "reopen" this, but I am not seeing the Linux arm64 wheel on pypi: https://pypi.org/simple/confluent-kafka/

Is this expected?

@anchitj
Copy link
Member Author

anchitj commented Feb 9, 2023

@mauriciogardini They will be available with the next release.

@mauriciogardini
Copy link

Thanks, @anchitj !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants