Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue related to import error of TopicCollection and TopicPartitionInfo classes when importing through other module like mypy #1764

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

pranavrth
Copy link
Member

Fixes #1732

@pranavrth pranavrth requested a review from a team as a code owner June 6, 2024 10:50
@pranavrth pranavrth changed the title Fixed an issue related to import error of and classes when importing through other module like mypy Fixed an issue related to import error of TopicCollection and TopicPartitionInfo classes when importing through other module like mypy Jun 6, 2024
Copy link
Member

@anchitj anchitj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@emasab emasab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@pranavrth pranavrth merged commit dd5e0b6 into master Jun 20, 2024
2 checks passed
@pranavrth pranavrth deleted the dev_fix-import-error-topic-collection branch June 20, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TopicCollection is missing in __all__
3 participants