Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show the error details when failing to register a schema #673

Closed
wants to merge 1 commit into from
Closed

Show the error details when failing to register a schema #673

wants to merge 1 commit into from

Conversation

jacopofar
Copy link
Contributor

I found out that if there are issues communicating with the schema registry the library raises an exception including the HTTP status but no further description of the problem.

This PR adds the content of the response to the exception to facilitate troubleshooting.

@jacopofar
Show the error details when failing to register a schema
727011b 
When there are issues during the call to the schema registry,
do not just report the HTTP code but also the response from the
server.
@ghost
Copy link

ghost commented Sep 30, 2019

It looks like @jacopofar hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

@jacopofar
Copy link
Contributor Author

[clabot:check]

@ghost
Copy link

ghost commented Sep 30, 2019

@confluentinc It looks like @jacopofar just signed our Contributor License Agreement. 👍

Always at your service,

clabot

@edenhill edenhill added the serdes Avro, JSON, Protobof, Schema-registry label Mar 9, 2021
mhowlett
mhowlett approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@mhowlett mhowlett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @jacopofar . ideally this information would be exposed programmatically on ClientError as well, but this is certainly a step forward, so we'll take it :-).

maybe worth noting this being depreciated eventually in favor of the new serde approach.

@mhowlett mhowlett mentioned this pull request Mar 11, 2021
Merged
@mhowlett
Copy link
Contributor

merged via #1056

@mhowlett mhowlett closed this Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhowlett mhowlett mhowlett approved these changes

Assignees
No one assigned
Labels
serdes Avro, JSON, Protobof, Schema-registry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jacopofar @mhowlett @edenhill