Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error with trailing slash at the end #749

Merged
merged 1 commit into from Dec 28, 2019
Merged

fix error with trailing slash at the end #749

merged 1 commit into from Dec 28, 2019

Conversation

IvanProdaiko94
Copy link
Contributor

To whom it may concern:

if you define the url for schema registry with / in the end, the lib will construct the wrong one.

Example:
schema_registy_host=http://localhost:1234/
will lead to http://localhost:1234//schemas/whatever_next

The lib does strip the / at the end of the string here

but several lines below get the deleted url from config with '/'.

So, with this fix there will be no error if the path of the schema registry will be defined like so:
http://localhost:1234/

@ghost
Copy link

ghost commented Dec 18, 2019

It looks like @IvanProdaiko94 hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

@IvanProdaiko94
Copy link
Contributor Author

[clabot:check]

@ghost
Copy link

ghost commented Dec 18, 2019

@confluentinc It looks like @IvanProdaiko94 just signed our Contributor License Agreement. 👍

Always at your service,

clabot

@rnpridgeon
Copy link
Contributor

rnpridgeon commented Dec 23, 2019

🤦‍♂ , good catch. Why not pop the url from the dict up here though

https://github.com/confluentinc/confluent-kafka-python/pull/749/files#diff-c96bedd6523a440fc267c9e78106496bL88

Also please add a unit test that validates the trailing "/" is stripped from the url to avoid future regressions.

@IvanProdaiko94
Copy link
Contributor Author

@rnpridgeon so, I did what you asked about)

Copy link
Contributor

@rnpridgeon rnpridgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for @IvanProdaiko94!

@rnpridgeon rnpridgeon merged commit 143c37b into confluentinc:master Dec 28, 2019
@IvanProdaiko94 IvanProdaiko94 deleted the fix_trailing_slash branch December 30, 2019 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants