Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Zookeeper timeout from 6000ms to 18000ms as per defaults in 5… #175

Merged
merged 1 commit into from
Feb 3, 2020

Conversation

JumaX
Copy link
Contributor

@JumaX JumaX commented Jan 23, 2020

….4.0 release.

Description

Updated zookeeper.connection.timeout.ms from 6000ms to 18000ms as per the new default with the 5.4.0 release of CP.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Deployed a full cluster on AWS on RHEL 7 to confirm change takes affect.

Test Configuration:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@JumaX
Copy link
Contributor Author

JumaX commented Jan 23, 2020

@domenicbove please review when you have a moment.

@JumaX JumaX self-assigned this Jan 23, 2020
@JumaX JumaX added the bug Something isn't working label Jan 23, 2020
Copy link
Contributor

@domenicbove domenicbove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this what we are taking as the source of truth for the prop, or is it written elsewhere: https://cwiki.apache.org/confluence/display/KAFKA/KIP-537%3A+Increase+default+zookeeper+session+timeout

Looks fine

@JumaX JumaX merged commit 0f6cf12 into 5.4.0-post Feb 3, 2020
@JumaX JumaX deleted the zookeeper_defaults branch February 3, 2020 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants