Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Remove PR template #29

Merged
merged 1 commit into from
Sep 15, 2020
Merged

MINOR: Remove PR template #29

merged 1 commit into from
Sep 15, 2020

Conversation

C0urante
Copy link

This template isn't necessary here; we can remove it.

@C0urante C0urante changed the base branch from master to 2.0.x September 15, 2020 17:20
@C0urante C0urante requested review from criccomini, whynick1 and a team September 15, 2020 17:20
Copy link

@cyrusv cyrusv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why doesn't this apply? My understanding is this is standard across all connectors

@C0urante
Copy link
Author

It's pretty Confluent-centric and involves some red tape that we shouldn't force on open source community members who've come here after the migration from WePay. We can think about adding a template more fitting for this project at some point down the road but things like "release strategy" and "Does this solution apply anywhere else?" aren't going to be useful for anyone who doesn't work at Confluent and should be removed ASAP.

@ncliang
Copy link

ncliang commented Sep 15, 2020

I've seen the template cause confusion in our other open source repositories as well (JDBC). IMO, there are fields that are still relevant (testing, problem, solution) and fields that we can remove as being not-so-relevant (does this apply anywhere else, release plan). We could just remove those fields that aren't relevant and keep the others (and apply to other open source repos)? WDYT @C0urante

@cyrusv
Copy link

cyrusv commented Sep 15, 2020

I see your point that it is geared toward proprietary connectors. I think a good template for open source is great for improving community PR hygiene, so I encourage us to keep some template optimized for community

@C0urante
Copy link
Author

This template was added when this was a mostly-private fork of an open-source repo, and without being contributed back to that upstream repo. If WePay people like the idea of a template and want to keep it then we can, but otherwise I think it's better to remove it and reduce the friction from the migration process.

Copy link

@ncliang ncliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with removing to ease the transition while we come up with a general purpose template suitable for our community connectors.

@C0urante C0urante mentioned this pull request Sep 15, 2020
@C0urante C0urante merged commit 2efd29a into confluentinc:2.0.x Sep 15, 2020
@C0urante
Copy link
Author

Thanks guys--I've merged this for now and filed #30 to keep track of the proposal for a PR template.

@C0urante C0urante deleted the remove-pr-template branch September 15, 2020 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants