-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: Remove PR template #29
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why doesn't this apply? My understanding is this is standard across all connectors
It's pretty Confluent-centric and involves some red tape that we shouldn't force on open source community members who've come here after the migration from WePay. We can think about adding a template more fitting for this project at some point down the road but things like "release strategy" and "Does this solution apply anywhere else?" aren't going to be useful for anyone who doesn't work at Confluent and should be removed ASAP. |
I've seen the template cause confusion in our other open source repositories as well (JDBC). IMO, there are fields that are still relevant (testing, problem, solution) and fields that we can remove as being not-so-relevant (does this apply anywhere else, release plan). We could just remove those fields that aren't relevant and keep the others (and apply to other open source repos)? WDYT @C0urante |
I see your point that it is geared toward proprietary connectors. I think a good template for open source is great for improving community PR hygiene, so I encourage us to keep some template optimized for community |
This template was added when this was a mostly-private fork of an open-source repo, and without being contributed back to that upstream repo. If WePay people like the idea of a template and want to keep it then we can, but otherwise I think it's better to remove it and reduce the friction from the migration process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with removing to ease the transition while we come up with a general purpose template suitable for our community connectors.
Thanks guys--I've merged this for now and filed #30 to keep track of the proposal for a PR template. |
This template isn't necessary here; we can remove it.