Support n:1 to topic2TableMap (topic:table) #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@b-goyal thanks for check PR! |
|
@jx2lee - build passes, good to merge. Could you please rebase the branch to 2.5.x (instead of master) ? |
|
@b-goyal success to chnage root branch (master to 2.5.x) check this out, please/ |
|
Modified the PR base branch to 2.5.x as well. @jx2lee |
|
thanks, @b-goyal |
|
Jenkins build is failing, re-tried a few times. I will take a look into it and approve the PR once this build is fixed. |
|
okay, i got it. thanks for pr-review |
|
@b-goyal could you tell me how long failed build will be fixed? |
|
Hey @jx2lee, was out for a few days. I will check and get back on this by end of next week. |
b-goyal
approved these changes
Nov 22, 2023
C0urante
referenced
this pull request
in Aiven-Open/bigquery-connector-for-apache-kafka
Feb 22, 2024
* enable n:1 * modified unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
like snowflow sink connector, it would be nice to have this.
snowflakedb/snowflake-kafka-connector#459
I haven't written an integration test code because integration tests don't work well locally. Do I need to?