CC-12621: add config combo validator for ssl configs #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prathibha-m
approved these changes
Oct 30, 2020
| @@ -72,7 +76,7 @@ private void validateCredentials() { | |||
| boolean onlyOneSet = config.username() != null ^ config.password() != null; | |||
There was a problem hiding this comment.
We can use StringUtils.isBlank to ensure it's not empty whitespaces and null
levzem
force-pushed
the
multi
branch
3 times, most recently
from
94b6da5
to
2189cb1
Compare
Signed-off-by: Lev Zemlyanov <lev@confluent.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lev Zemlyanov lev@confluent.io
Problem
the connector does not validate different combinations of SSL configs
Solution
add validator to validate that SSL configs are only specified when elasticsearch.security.protocol is set to
SSLDoes this solution apply anywhere else?
If yes, where?
proxy and connection configs need to be validated as well
Test Strategy
add unit tests for both valid and invalid combinations for ssl configs
Testing done:
Release Plan
backport to
5.2.xwhere the ssl configs were introduced