Drop invalid messages if needed

[patsak]

No description provided.

[ghost]

It looks like @patsak hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

[ConfluentJenkins]

Can one of the admins verify this patch?

[ewencp]

@patsak Are there cases where we expect to fail to convert the data? I'm not sure whether a setting for this makes sense -- if there's a bug in the conversion code, we should just fix that.

[patsak]

@ewencp Producer has written message without key for example - https://github.com/confluentinc/kafka-connect-elasticsearch/blob/master/src/main/java/io/confluent/connect/elasticsearch/DataConverter.java#L56-L58
Or user make a mistake and write messages for other topic.
In this cases connector stuck on this messages forever.

[ewencp]

@patsak Ok, that makes sense. Do you want to rebase and re-target to 3.4.x? That'd get the change released most quickly.

As it is, the change looks good aside from merge conflicts.

[patsak]

[clabot:check]

[ghost]

@confluentinc It looks like @patsak just signed our Contributor License Agreement. 👍

Always at your service,

clabot

[patsak]

@ewencp I've retargeted branch with merge conflicts resolving and style fixes.

[ewencp]

ok to test

[ewencp]

Great, looks good. Thanks for the contribution @patsak!