CC-2515: Open temp Parquet files with OVERWRITE mode #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the `ParquetRecordWriterProvider` class to open the `AvroParquetWriter` instance for each Parquet file with ‘overwrite’ mode. This required using the `AvroParquetWriter.Builder` class rather than the deprecated constructor, which did not have a way to specify the mode.
rhauch
changed the title
kkonstantine
reviewed
Aug 9, 2018
| conf.getHadoopConfiguration() | ||
| ); | ||
| writer = AvroParquetWriter.<GenericRecord>builder(path) | ||
| .withSchema(avroSchema) |
There was a problem hiding this comment.
I believe the format in multiline chained calls is still 2 tabs in in connectors. Not a big deal though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the
ParquetRecordWriterProviderclass to open theAvroParquetWriterinstance for each Parquet temp file with ‘overwrite’ mode. This required using theAvroParquetWriter.Builderclass rather than the deprecated constructor, which did not have a way to specify the mode.The Avro format's writer already uses an "overwrite" mode, so this brings the same behavior to the Parquet format.
Note that the connector "commits" the records written to a temp file by closing it and moving it to the final location, as part of the HDFS connector's write ahead log behavior. The change in this PR is useful when the connector restarts and there's already an existing Parquet temp file; without this change a
FileAlreadyExistsExceptionis thrown.