Revert "Allow close() on CachedConnectionProvider while attempting to connect…" #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ypmahajan
approved these changes
Nov 30, 2022
mukkachaitanya
deleted the
revert-1206-improve-connection-provider-close
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Reverts #1206
Why?
We missed a big part of the fact that the internal retries of the ConnectionProvider also call on
close.For example, JdbcDbWriter#closeQuitely is called during internal retries JdbcSinkTask#put. This can cause NPEs as we return a null connection back when a new connection is requested since we have set
isRunningto false.This regression wasn't caught by 5.0.x tests. It failed further down on the pint merge on newer branches.