[Minor] Fix upstream tests failing due to #1284 #1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -78,7 +78,7 @@ protected CachedConnectionProvider connectionProvider( | |||
|
|
|||
| // Should request a connection, then should close it on stop() | |||
| EasyMock.expect(mockCachedConnectionProvider.getConnection()).andReturn(db.getConnection()).anyTimes(); | |||
| mockCachedConnectionProvider.close(); | |||
| mockCachedConnectionProvider.close(true); | |||
There was a problem hiding this comment.
@mukkachaitanya what does passing "true" mean?
There was a problem hiding this comment.
True implies that the connector is stopping and we want to close the ConnectionProvider entirely. False means that the connector is closing the connection when it faces some transient errors. This was introduced as part of #1284
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JdbcSourceTaskLifecycleTests were failing due to a change to API introduced as part of #1284