Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary surefire configuration overrides. #288

Merged
merged 1 commit into from Sep 18, 2017

Conversation

ewencp
Copy link
Contributor

@ewencp ewencp commented Sep 18, 2017

No description provided.

@ewencp ewencp requested a review from a team September 18, 2017 17:55
@ewencp
Copy link
Contributor Author

ewencp commented Sep 18, 2017

This override shouldn't be setting the version and only included a configuration that is already included in the common pom but didn't include some other configs which enable recording of coverage, so we weren't getting proper coverage reporting in Jenkins.

Copy link
Member

@rhauch rhauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ewencp ewencp changed the base branch from master to 3.4.x September 18, 2017 20:45
@ewencp ewencp merged commit b01556d into confluentinc:3.4.x Sep 18, 2017
@ewencp ewencp deleted the remove-surefire-override branch September 18, 2017 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants