Use new config definition #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ewencp JDBC connector using new config definition. |
|
|
||
| public static final String BATCH_MAX_ROWS_CONFIG = "batch.max.rows"; | ||
| private static final String BATCH_MAX_ROWS_DOC = | ||
| "Maximum number of rows to include in a single batch when polling for new data. This " | ||
| + "setting can be used to limit the amount of data buffered internally in the connector."; | ||
| public static final int BATCH_MAX_ROWS_DEFAULT = 100; | ||
| private static final String BATCH_MAX_ROWS_DISPLAY = "Batch Max Rows"; |
There was a problem hiding this comment.
How many characters do we have? Perhaps "Maximum number of rows per batch"? or "Rows per batch limit"?
Display should probably be close to human english....
There was a problem hiding this comment.
The length of the display name should be close to the length of the typical value for the config. How about "Max rows per batch" ?
…alls to get database metadata in a simple start/stop test.
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.