-
Notifications
You must be signed in to change notification settings - Fork 954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add schema evolution in doc #59
Conversation
---------------- | ||
|
||
The JDBC connector supports schema evolution. When there is a change in a database table schema, | ||
the JDBC connector can detect the change, create a new Kafka connect schema and try to register |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kafka Connect should be capitalized
@Ishiihara In addition to other comments, we should make sure capitalization of Schema Registry is consistent with the rest of the documentation. |
@ewencp Addressed the review comments and add more explanation on the complexity of getting the default table column values. |
9032de4
to
f22b33e
Compare
Schema Evolution | ||
---------------- | ||
|
||
The JDBC connector supports schema evolution. When there is a change in a database table schema, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, one last point I realized -- do we want to mention that this is specific to using AvroConverter
? If we're not using AvroConverter
, then obviously a lot of this doesn't apply... The first set of statements up to the new Kafka Connect schema make sense, but everything after assumes AvroConverter.
@Ishiihara Left some follow up items, but LGTM. Feel free to merge once those issues are resolved. |
f22b33e
to
1ac742b
Compare
1ac742b
to
3496925
Compare
@ewencp @gwenshap @hachikuji