Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schema evolution in doc #59

Merged
merged 1 commit into from
Apr 4, 2016
Merged

Add schema evolution in doc #59

merged 1 commit into from
Apr 4, 2016

Conversation

Ishiihara
Copy link
Contributor

----------------

The JDBC connector supports schema evolution. When there is a change in a database table schema,
the JDBC connector can detect the change, create a new Kafka connect schema and try to register
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kafka Connect should be capitalized

@ewencp
Copy link
Contributor

ewencp commented Apr 4, 2016

@Ishiihara In addition to other comments, we should make sure capitalization of Schema Registry is consistent with the rest of the documentation.

@Ishiihara
Copy link
Contributor Author

@ewencp Addressed the review comments and add more explanation on the complexity of getting the default table column values.

Schema Evolution
----------------

The JDBC connector supports schema evolution. When there is a change in a database table schema,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, one last point I realized -- do we want to mention that this is specific to using AvroConverter? If we're not using AvroConverter, then obviously a lot of this doesn't apply... The first set of statements up to the new Kafka Connect schema make sense, but everything after assumes AvroConverter.

@ewencp
Copy link
Contributor

ewencp commented Apr 4, 2016

@Ishiihara Left some follow up items, but LGTM. Feel free to merge once those issues are resolved.

@Ishiihara Ishiihara merged commit 22024df into master Apr 4, 2016
@Ishiihara Ishiihara deleted the doc-schema-evolution branch May 19, 2016 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants