Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rely on jackson.version from common pom instead of defining it ourselves #148

Merged
merged 1 commit into from Mar 8, 2018

Conversation

ewencp
Copy link
Contributor

@ewencp ewencp commented Mar 7, 2018

No description provided.

@ewencp ewencp requested a review from a team March 7, 2018 00:09
@ewencp
Copy link
Contributor Author

ewencp commented Mar 7, 2018

See confluentinc/common#102 for where we're moving this to a more central location to make updating versions easier. This is as far back as we were relying on the common pom. Build won't pass until we get the other one merged and builds for 4.0.x common go through.

Copy link
Member

@kkonstantine kkonstantine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ewencp ewencp mentioned this pull request Mar 7, 2018
@ewencp ewencp force-pushed the rely-on-common-jackson-version branch from d1cf703 to d61d4cb Compare March 7, 2018 23:31
@ewencp ewencp force-pushed the rely-on-common-jackson-version branch from d61d4cb to 22d8755 Compare March 7, 2018 23:56
@ewencp ewencp merged commit a144ce8 into confluentinc:4.0.x Mar 8, 2018
@ewencp ewencp deleted the rely-on-common-jackson-version branch March 8, 2018 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants