CC-918: Update build to generate plugin package #155
Conversation
There was a problem hiding this comment.
Thanks for tackling this, @wicknicks! Looks pretty good overall, got a few small comments. Also, we probably want to add some non-Confluent logo files before merging but as per our offline discussion that'll have to wait until we do some research about licensing.
kafka-connect-s3/pom.xml
Outdated
| </tags> | ||
|
|
||
| <requirements> | ||
| <requirement>Confluent Platform installed and running</requirement> |
There was a problem hiding this comment.
We can probably leave this out as per @rhauch's comments on the other related PRs (confluentinc/kafka-connect-hdfs#307 "Shouldn't a user be able to install this with just AK?")
kafka-connect-s3/pom.xml
Outdated
| <supportProviderName>Confluent, Inc.</supportProviderName> | ||
| <supportSummary>Confluent supports the S3 sink connector alongside community members as part of its Confluent Platform open source offering.</supportSummary> | ||
| <supportUrl>https://docs.confluent.io/current/</supportUrl> | ||
| <supportLogo>logos/confluent.png</supportLogo> |
There was a problem hiding this comment.
Either this element should be removed for now, or a logos/ directory should be created with the confluent.png image in it.
kafka-connect-s3/pom.xml
Outdated
| @@ -197,6 +197,53 @@ | |||
| </dependency> | |||
| </dependencies> | |||
| </plugin> | |||
| <plugin> | |||
| <groupId>io.confluent</groupId> | |||
| <version>0.9.0</version> | |||
There was a problem hiding this comment.
This version generates incorrectly-structured archive files, so we'll need to make sure to update this to either 0.9.1 or 1.0.0 (whichever is available at the time) before merging this PR.
There was a problem hiding this comment.
Fixed other comments. Will update this once you push your changes. Thanks!
kafka-connect-s3/pom.xml
Outdated
| <ownerType>organization</ownerType> | ||
| <ownerName>Confluent, Inc.</ownerName> | ||
| <ownerUrl>https://confluent.io/</ownerUrl> | ||
| <ownerLogo>logos/confluent.png</ownerLogo> |
There was a problem hiding this comment.
See comment RE: supportLogo
kafka-connect-s3/pom.xml
Outdated
| <goal>kafka-connect</goal> | ||
| </goals> | ||
| <configuration> | ||
| <title>Kafka Connect Storage Cloud</title> |
There was a problem hiding this comment.
This should probably be Kafka Connect S3.
Signed-off-by: Arjun Satish <arjun@confluent.io>
Signed-off-by: Arjun Satish <arjun@confluent.io>
Signed-off-by: Arjun Satish <arjun@confluent.io>
Signed-off-by: Arjun Satish <arjun@confluent.io>
|
@wicknicks as per offline discussion, can we set |
Signed-off-by: Arjun Satish <arjun@confluent.io>
Signed-off-by: Arjun Satish arjun@confluent.io