Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCMSG-861: Catch additional exception to report in DLQ #392

Merged
merged 1 commit into from Mar 2, 2021
Merged

CCMSG-861: Catch additional exception to report in DLQ #392

merged 1 commit into from Mar 2, 2021

Conversation

dosvath
Copy link
Contributor

@dosvath dosvath commented Mar 2, 2021 •
edited

Problem

There is an additional opportunity to catch and report an exception to the DLQ.

Solution

Catch exception on encodePartition and report it to the DLQ using the reporter if available.

Does this solution apply anywhere else?
  • yes
  • no
If yes, where?

Test Strategy

Testing done:
  • Unit tests
  • Integration tests
  • System tests
  • Manual tests

Release Plan

10.0.x the earliest DLQ branch.

@dosvath dosvath requested a review from a team as a code owner March 2, 2021 22:20
levzem
levzem approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@levzem levzem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosvath dosvath merged commit 4427088 into confluentinc:10.0.x Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levzem levzem levzem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dosvath @levzem