Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CC-21917 | Added support for decimal.format config to be passed to json formatter. #673

Merged
merged 1 commit into from Aug 18, 2023

Conversation

pbadani
Copy link
Member

@pbadani pbadani commented Aug 16, 2023

Problem

Solution

Added support for decimal.format config to be passed to json formatter.

Does this solution apply anywhere else?
  • yes
  • no
If yes, where?

Test Strategy

Testing done:
  • Unit tests
  • Integration tests
  • System tests
  • Manual tests

Release Plan

@pbadani pbadani requested a review from a team as a code owner August 16, 2023 05:31
@cla-assistant
Copy link

cla-assistant bot commented Aug 16, 2023

CLA assistant check
All committers have signed the CLA.

@cla-assistant
Copy link

cla-assistant bot commented Aug 16, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@aniketshrimal aniketshrimal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @pbadani! Thanks for the PR.

@pbadani pbadani merged commit 1087a61 into 10.0.x Aug 18, 2023
3 checks passed
@pbadani pbadani deleted the pbadani/CC-21917 branch August 18, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants