Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for regression from CVE fix in PR #660 #680

Merged
merged 3 commits into from Sep 11, 2023
Merged

Conversation

ashoke-cube
Copy link
Contributor

@ashoke-cube ashoke-cube commented Sep 11, 2023

Problem

Excluding hadoop-shaded-guava for CVE fix in commit 8a80a19
resulted in a regression with NoClassDefFoundError: org/apache/hadoop/thirdparty/com/google/common/collect/Interners
while using the io.confluent.connect.s3.format.parquet.ParquetFormat for format.class field in config.

Solution

kafka-connect-storage-common has an updated hadoop-shaded-guava without the CVE.

Does this solution apply anywhere else?
  • yes
  • no
If yes, where?

Test Strategy

Testing done:
  • Unit tests
  • Integration tests
  • System tests
  • Manual tests

Release Plan

@ashoke-cube ashoke-cube requested a review from a team as a code owner September 11, 2023 05:19
@cla-assistant
Copy link

cla-assistant bot commented Sep 11, 2023

CLA assistant check
All committers have signed the CLA.

@cla-assistant
Copy link

cla-assistant bot commented Sep 11, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@pbadani pbadani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after testing with parquet input format in docker playground.

@ashoke-cube ashoke-cube merged commit 8ee3c2f into 10.0.x Sep 11, 2023
1 check passed
@ashoke-cube ashoke-cube deleted the cve_regression_fix branch September 11, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants