Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix#1065 #1067

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Commits on Sep 23, 2022

  1. fix#1065

    fter few days of experiments found the root cause.
    
    Closes confluentinc#1065
    
    Few details on the fix:
    KafkaConsumerManager's "Consumer Expiration Thread" acquires a lock on (KafkaConsumerManager.this instance) and calls expired method of KafkaConsumerState.java. The Consumer Expiration Thread sometimes takes time to get the lock on synchronized expired because there can be a consumer consuming records that has a lock on the KafkaConsumerState instance which may take longer to release depending on the time taken in the IO to fetch the records from kafka broker. The situation can get worse with more number of active consumers fetching records.
    
    The two locks for expired and updateExpiration are not required.
    
    Thread dump snippets
    "qtp1551629761-29" prio=5 Id=29 BLOCKED on io.confluent.kafkarest.v2.KafkaConsumerManager@3a09eed4 owned by "Consumer Expiration Thread" Id=47
     at app//io.confluent.kafkarest.v2.KafkaConsumerManager.getConsumerInstance(KafkaConsumerManager.java:669)
     -  blocked on io.confluent.kafkarest.v2.KafkaConsumerManager@3a09eed4 at app//io.confluent.kafkarest.v2.KafkaConsumerManager.getConsumerInstance(KafkaConsumerManager.java:679)
    
    "qtp1551629761-35" prio=5 Id=35 BLOCKED on io.confluent.kafkarest.v2.KafkaConsumerManager@3a09eed4 owned by "Consumer Expiration Thread" Id=47
     at app//io.confluent.kafkarest.v2.KafkaConsumerManager.createConsumer(KafkaConsumerManager.java:180)
     -  blocked on io.confluent.kafkarest.v2.KafkaConsumerManager@3a09eed4 
    
    "Consumer Expiration Thread" daemon prio=5 Id=47 BLOCKED on io.confluent.kafkarest.v2.JsonKafkaConsumerState@4d2bbeda owned by "pool-4-thread-13" Id=153
     at app//io.confluent.kafkarest.v2.KafkaConsumerState.expired(KafkaConsumerState.java:345)
     -  blocked on io.confluent.kafkarest.v2.JsonKafkaConsumerState@4d2bbeda at app//io.confluent.kafkarest.v2.KafkaConsumerManager$ExpirationThread.run(KafkaConsumerManager.java:761)
     -  locked io.confluent.kafkarest.v2.KafkaConsumerManager@3a09eed4
    
    "pool-4-thread-13" prio=5 Id=153 RUNNABLE (in native)
     at java.base@11.0.16.1/sun.nio.ch.EPoll.wait(Native Method)
     at java.base@11.0.16.1/sun.nio.ch.EPollSelectorImpl.doSelect(EPollSelectorImpl.java:120)
     at java.base@11.0.16.1/sun.nio.ch.SelectorImpl.lockAndDoSelect(SelectorImpl.java:124)
     -  locked sun.nio.ch.Util$2@1458190c
     -  locked sun.nio.ch.EPollSelectorImpl@3ebca1e6
     at java.base@11.0.16.1/sun.nio.ch.SelectorImpl.select(SelectorImpl.java:136)
     at app//org.apache.kafka.common.network.Selector.select(Selector.java:869)
     at app//org.apache.kafka.common.network.Selector.poll(Selector.java:465)
     at app//org.apache.kafka.clients.NetworkClient.poll(NetworkClient.java:561)
     at app//org.apache.kafka.clients.consumer.internals.ConsumerNetworkClient.poll(ConsumerNetworkClient.java:265)
    swapnilgawade16 committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    dfa1373 View commit details
    Browse the repository at this point in the history