KREST-8943 Add an integration test with multiple consumers in parallel. #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipnee
reviewed
Jan 27, 2023
kafka-rest/src/test/java/io/confluent/kafkarest/integration/ConsumerJsonTest.java
Show resolved
Hide resolved
kafka-rest/src/test/java/io/confluent/kafkarest/integration/ConsumerJsonTest.java
Outdated
Show resolved
Hide resolved
msn-tldr
force-pushed
the
add_two_consumer_test
branch
2 times, most recently
from
10dfec9
to
f17ed32
Compare
|
seems to be failing. Has this been failing consistently? |
This test will setup 2 consumers, each subscribed to the same topic, and that do multiple consumes(GET on /records/) in parallel.
msn-tldr
force-pushed
the
add_two_consumer_test
branch
from
ee049d2
to
cb58f0f
Compare
TemirAskhat
approved these changes
Feb 16, 2023
| 1, | ||
| consumer1Done, | ||
| consumer1ReadyForConsumeLoop, | ||
| consumer0ReadyForConsumeLoop /* otherConsumerReadyForConsumeLoop */)); |
There was a problem hiding this comment.
[nit] Do we really need those comments?
| Versions.KAFKA_V2_JSON_JSON, | ||
| Versions.KAFKA_V2_JSON_JSON, | ||
| jsonConsumerRecordType, | ||
| /* converter= */ null, |
There was a problem hiding this comment.
[nit] Same as below :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test will setup 2 consumers, each subscribed to the same topic, and that do multiple consumes(GET on /records/) in parallel.