Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Required query parms and errors for ACL operations #1126

Merged
merged 2 commits into from Mar 9, 2023
Merged

Required query parms and errors for ACL operations #1126

merged 2 commits into from Mar 9, 2023

Conversation

AndrewJSchofield
Copy link
Member

No description provided.

@AndrewJSchofield AndrewJSchofield requested a review from a team as a code owner March 9, 2023 10:51
@AndrewJSchofield
Copy link
Member Author

Build failure looks unrelated to the PR.

[ERROR] Failed to execute goal on project confluent-cloud-ksql-security: Could not resolve dependencies for project io.confluent:confluent-cloud-ksql-security:jar:7.5.0-99999: Could not find artifact io.confluent.cloud:events-schema:jar:1.155.0 in confluent-codeartifact-central (https://confluent-519856050701.dp.confluent.io/maven/maven-public/) -> [Help 1]

@AndrewJSchofield AndrewJSchofield mentioned this pull request Mar 9, 2023
Closed
@AndrewJSchofield AndrewJSchofield merged commit 7e69329 into master Mar 9, 2023
@AndrewJSchofield AndrewJSchofield deleted the KREST-8062 branch March 9, 2023 15:37
msn-tldr
msn-tldr reviewed Mar 10, 2023
View reviewed changes
api/v3/openapi.yaml
@@ -193,13 +193,13 @@ paths:
tags:
- ACL (v3)
parameters:
- $ref: '#/components/parameters/AclResourceType'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndrewJSchofield how did you find the inconsistencies/mistakes in the openapi.yaml? Is there a linter to do it? or good old hard-core eye-balling the code/docs?
Its the former, then we can look to automate it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A combination of JIRAs, reading the spec, running the code and having beady eyes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msn-tldr msn-tldr msn-tldr left review comments

@apoorvmittal10 apoorvmittal10 apoorvmittal10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AndrewJSchofield @apoorvmittal10 @msn-tldr