Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KREST-6569 - Cope with partitions disappearing #1138

Merged
merged 1 commit into from Mar 28, 2023
Merged

Conversation

AndrewJSchofield
Copy link
Member

The GET v3/clusters/{}/brokers/{}/partition-replicas operation issues multiple calls to AdminClient. In the event that a topic is deleted between the first call and the later calls, it's possible that topic-partitions found in the first call are not found in the later calls. The appropriate action in this case is just to remove them from the response, rather than failing with a 404.

@AndrewJSchofield AndrewJSchofield requested a review from a team as a code owner March 27, 2023 19:46
Copy link

@lianetm lianetm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@trnguyencflt trnguyencflt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AndrewJSchofield AndrewJSchofield merged commit d31122f into master Mar 28, 2023
3 checks passed
@AndrewJSchofield AndrewJSchofield deleted the KREST-6569 branch March 28, 2023 14:34
@msn-tldr
Copy link
Member

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants