KREST-10313 Prototype of batch REST Produce #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kafka-rest/src/main/java/io/confluent/kafkarest/resources/v3/ProduceBatchAction.java
Outdated
Show resolved
Hide resolved
kafka-rest/src/main/java/io/confluent/kafkarest/resources/v3/ProduceBatchAction.java
Show resolved
Hide resolved
kafka-rest/src/main/java/io/confluent/kafkarest/resources/v3/ProduceBatchAction.java
Outdated
Show resolved
Hide resolved
kafka-rest/src/main/java/io/confluent/kafkarest/resources/v3/ProduceBatchAction.java
Show resolved
Hide resolved
msn-tldr
reviewed
May 23, 2023
| @@ -2330,6 +2424,44 @@ components: | |||
| nullable: true | |||
| nullable: true | |||
|
|
|||
| ProduceBatchRequest: | |||
There was a problem hiding this comment.
Do run it through various open-api linters.
There was a problem hiding this comment.
Yes, I will do when I'm ready.
| ProduceBatchResponse: | ||
| description: |- | ||
| The response containing a delivery report for each record produced to a topic. | ||
| A separate delivery report will be returned, in the same order, each with its own error_code. |
There was a problem hiding this comment.
nit: I think it should mention a high level list of "error_codes" to expect in a delivery report.
kafka-rest/src/main/java/io/confluent/kafkarest/resources/v3/ProduceBatchAction.java
Show resolved
Hide resolved
kafka-rest/src/main/java/io/confluent/kafkarest/resources/v3/ProduceBatchAction.java
Show resolved
Hide resolved
| executorService); | ||
| } | ||
|
|
||
| private CompletableFuture<ProduceBatchResultEntry> produce( |
There was a problem hiding this comment.
Is there a way to better organize this code? 🤔
with 2 ProduceAction*.java files, any future modifications like to rate-limiting, billing would have to be in 2 places, not ideal.
Maybe divide the logic into 2 bits -
- "internal-facing-logic" - this will the common produce bits, like "actual produce", rate-limiting, billing etc.
- "external-facing" Produce*Action.java that validations, ser & deser for external data-strucutures.
What do you think?
There was a problem hiding this comment.
This is probably ripe for refactoring when it's settled down a bit.
kafka-rest/src/main/java/io/confluent/kafkarest/resources/v3/ProduceBatchAction.java
Show resolved
Hide resolved
msn-tldr
reviewed
May 24, 2023
| import org.junit.jupiter.api.BeforeEach; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| public class ProduceBatchActionTest { |
msn-tldr
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative to streaming REST Produce based on an array of requests and responses.