Review logging, some code tidy up #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trnguyencflt
force-pushed
the
KREST-11025-logging-improvements
branch
from
2f203ce
to
cc7e976
Compare
trnguyencflt
commented
Jul 12, 2023
| @@ -47,7 +47,7 @@ public class DefaultKafkaRestContext implements KafkaRestContext { | |||
| private SchemaRegistryClient schemaRegistryClient; | |||
|
|
|||
| public DefaultKafkaRestContext(KafkaRestConfig config) { | |||
| log.debug("Creating context with config: {}", config); | |||
There was a problem hiding this comment.
this doesn't actually log the configuration at the moment due to it use default toString() of Object, but changing this just in case.
AndrewJSchofield
approved these changes
Jul 12, 2023
trnguyencflt
commented
Jul 12, 2023
| @@ -113,7 +113,6 @@ private static RequestLog createRequestLog( | |||
| KafkaRestConfig config, | |||
| RequestLog.Writer requestLogWriter, | |||
| String requestLogFormat, | |||
| Logger log, | |||
There was a problem hiding this comment.
log is a static object, so we don't need to pass to this function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is as part of reviewing our logging, I have checked across the repository and confirm that we don't log configuration.