Create custom Properties and Map configs classes with toString method that hides password properties #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g method that hides password property
trnguyencflt
force-pushed
the
KREST-11068-create-custom-class-for-logging
branch
2 times, most recently
from
cb0cc8f
to
02161eb
Compare
trnguyencflt
changed the title
…chema registry) from KafkaRestConfig and add unittests.
trnguyencflt
force-pushed
the
KREST-11068-create-custom-class-for-logging
branch
from
02161eb
to
9ec4bf7
Compare
trnguyencflt
requested review from
apoorvmittal10,
AndrewJSchofield,
TemirAskhat,
msn-tldr and
ehumber
TemirAskhat
reviewed
Aug 22, 2023
kafka-rest/src/main/java/io/confluent/kafkarest/KafkaRestConfig.java
Outdated
Show resolved
Hide resolved
kafka-rest/src/main/java/io/confluent/kafkarest/KafkaRestConfig.java
Outdated
Show resolved
Hide resolved
kafka-rest/src/main/java/io/confluent/kafkarest/KafkaRestConfig.java
Outdated
Show resolved
Hide resolved
TemirAskhat
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add two classes (inner class of
KafkaRestConfig) that can be a direct replacement for the two classes that are often used in creating configurationThe two classes have overriden
toStringmethod that can hide sensitive configs.toStringis the function that will get called in logging on the class.This PR also uses the two new classes in all functions in
KafkaRestConfigthat return configurations so that they can be safely logged later.Reference JIRA: https://confluentinc.atlassian.net/browse/KREST-11068