Migrate internal entities to Google's Auto-Value. #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The amount of boilerplate code I had to write in my last PR (#677) to add two fields in a response, was just too much. Enough is enough, so I migrated our internal entities to use Google's Auto-Value, that auto-generates a lot of this boilerplate automatically.
|
For the uninitiated (myself) https://www.baeldung.com/introduction-to-autovalue |
rnpridgeon
approved these changes
May 26, 2020
There was a problem hiding this comment.
LGTM, prior to merging though I'd ensure that the changes to toString does not alter log messages in some material way. User log aggregation/analytic pipelines may rely on the log messages being in a particular format so any material change there would represent a breakting change.
| id, name, format, autoOffsetReset, autoCommitEnable, responseMinBytes, requestWaitMs); | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { |
There was a problem hiding this comment.
What's the effect of a change like this on logging?
There was a problem hiding this comment.
AutoValue will generate reasonably similar toStrings for these entities. Most of these entities, and their toStrings were added as part of 5.5 preview. I would not expect people to be depending on them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The amount of boilerplate code I had to write in my last PR (#677) to add two fields in a response, was just too much. Enough is enough, so I migrated our internal entities to use Google's Auto-Value, that auto-generates a lot of this boilerplate automatically.