minor: Update error message for retention config

confluentinc · Aug 24, 2022 · f9864ad · f9864ad
1 parent e93fe35
commit f9864ad
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/ksqldb-engine/src/main/java/io/confluent/ksql/topic/TopicCreateInjector.java b/ksqldb-engine/src/main/java/io/confluent/ksql/topic/TopicCreateInjector.java
@@ -209,7 +209,9 @@ private void throwIfRetentionPresentForTable(
   ) {
     if (topicCleanUpPolicy.equals(TopicConfig.CLEANUP_POLICY_COMPACT)
         && retentionInMillis.isPresent()) {
-      throw new KsqlException("Invalid config variable in the WITH clause: RETENTION_MS");
+      throw new KsqlException(
+          "Invalid config variable in the WITH clause: RETENTION_MS."
+          + " Non-windowed tables do not support retention.");
     }
   }
 
@@ -246,7 +248,7 @@ private TopicProperties createTopic(
     config.putAll(additionalTopicConfigs);
 
     // Note: The retention.ms config has no effect if cleanup.policy=compact
-    // cleanup.policy=compact is set for topics that are backed by tables
+    // config is set for topics that are backed by tables
     if (topicCleanUpPolicy.equals(TopicConfig.CLEANUP_POLICY_COMPACT)) {
       config.remove(TopicConfig.RETENTION_MS_CONFIG);
     }

diff --git a/ksqldb-engine/src/test/java/io/confluent/ksql/topic/TopicCreateInjectorTest.java b/ksqldb-engine/src/test/java/io/confluent/ksql/topic/TopicCreateInjectorTest.java
@@ -508,7 +508,10 @@ public void shouldThrowIfRetentionConfigPresentInCreateTable() {
     );
 
     // Then:
-    assertThat(e.getMessage(), containsString("Invalid config variable in the WITH clause: RETENTION_MS"));
+    assertThat(
+        e.getMessage(),
+        containsString("Invalid config variable in the WITH clause: RETENTION_MS."
+            + " Non-windowed tables do not support retention."));
   }
 
   @Test
@@ -523,7 +526,10 @@ public void shouldThrowIfRetentionConfigPresentInCreateTableAs() {
     );
 
     // Then:
-    assertThat(e.getMessage(), containsString("Invalid config variable in the WITH clause: RETENTION_MS"));
+    assertThat(
+        e.getMessage(),
+        containsString("Invalid config variable in the WITH clause: RETENTION_MS."
+            + " Non-windowed tables do not support retention."));
   }
 
   private ConfiguredStatement<?> givenStatement(final String sql) {