fix: add commmit suggestions

confluentinc · Aug 9, 2020 · fed21ae · fed21ae
1 parent b748f32
commit fed21ae
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/ksqldb-engine/src/main/java/io/confluent/ksql/planner/LogicalPlanner.java b/ksqldb-engine/src/main/java/io/confluent/ksql/planner/LogicalPlanner.java
@@ -146,7 +146,8 @@ public OutputNode buildPlan() {
     if (analysis.getRefinementInfo().isPresent()
         && analysis.getRefinementInfo().get().getOutputRefinement() == OutputRefinement.FINAL) {
       if (!ksqlConfig.getBoolean(KsqlConfig.KSQL_SUPPRESS_ENABLED)) {
-        throw new KsqlException("Suppression is currently disabled in the KsqlConfig.");
+        throw new KsqlException("Suppression is currently disabled. You can enable it by setting "
+            + KsqlConfig.KSQL_SUPPRESS_ENABLED + " to true");
       }
       if (!(analysis.getGroupBy().isPresent() && analysis.getWindowExpression().isPresent())) {
         throw new KsqlException("EMIT FINAL is only supported for windowed aggregations.");

diff --git a/ksqldb-streams/src/main/java/io/confluent/ksql/execution/streams/TableSuppressBuilder.java b/ksqldb-streams/src/main/java/io/confluent/ksql/execution/streams/TableSuppressBuilder.java
@@ -98,7 +98,7 @@ <K> KTableHolder<K> build(
     final long maxBytes = queryBuilder.getKsqlConfig().getLong(
         KsqlConfig.KSQL_SUPPRESS_BUFFER_SIZE);
 
-    if (maxBytes == -1) {
+    if (maxBytes < 0) {
       strictBufferConfig = Suppressed.BufferConfig.unbounded();
     } else {
       strictBufferConfig = Suppressed.BufferConfig