Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop requirement that CREATE TABLE must have KEY set in WITH clause. #2745

Closed
big-andy-coates opened this issue Apr 29, 2019 · 0 comments · Fixed by #2746
Closed

Drop requirement that CREATE TABLE must have KEY set in WITH clause. #2745

big-andy-coates opened this issue Apr 29, 2019 · 0 comments · Fixed by #2746

Comments

@big-andy-coates
Copy link
Contributor

big-andy-coates commented Apr 29, 2019

The requirement is excluding any use case where the topic data does not have a copy of the key in the value. It is also confusing users. It is already possible to have tables in the metastore that does not have a key field, consider:

CREATE TABLE T1 (ID INT, OTHER INT) WITH (KEY='ID', ...);
CREATE TABLE T2 AS SELECT OTHER FROM T1l;

T2 will not have a key field set as the source's key field is not in the projection.

The KEY property should be an optional optimisation hint, that allows KSQL to avoid unnecessary repartitions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant