Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support stream-stream joins #731

Closed
apurvam opened this issue Feb 14, 2018 · 3 comments
Closed

Support stream-stream joins #731

apurvam opened this issue Feb 14, 2018 · 3 comments
Assignees
@apurvam
Labels
enhancement

Comments

@apurvam
Copy link
Contributor

apurvam commented Feb 14, 2018 •
edited by miguno

Currently, you can only perform stream-table joins (stream: left, table: right). We should support stream-stream joins, too, similar to what Kafka's Streams API already supports.

Related tickets:
@IDispose
Copy link

table-table joins also should be supported.

@miguno miguno changed the title KSQL should support stream-stream joins Support stream-stream joins Feb 21, 2018
This was referenced Feb 21, 2018
Closed
Closed
@miguno
Copy link
Contributor

miguno commented Feb 21, 2018

@IDispose and @pouledodue : Please cast your +1 vote to the separate table-table join ticket that I just created: #760

@apurvam apurvam mentioned this issue Feb 22, 2018
Closed
@apurvam apurvam self-assigned this Apr 10, 2018
@apurvam apurvam mentioned this issue Jun 13, 2018
Merged
2 tasks
apurvam added a commit that referenced this issue Jun 18, 2018
@apurvam
Add new join types to KSQL (#1417)
25b492d 
This patch adds LEFT, OUTER, and INNER stream-stream and table-table joins. Additionally it adds an INNER stream-table join.

Majority of the logic is in JoinNode where a Joiner class hierarchy is introduced to do the heavy lifting of executing the right join. This hierarchy maximizes code reuse across the join types.

Lot's of redundant grammar constructs were removed as part of this patch. In particular, we had lexical support far JOIN USING instead of JOIN ON. We had support for CROSS joins in the grammar. These have been removed.

Fixes #731. Fixes #760 . Fixes #1380 .
@apurvam
Copy link
Contributor Author

apurvam commented Jun 18, 2018

Fixed by #1417

@apurvam apurvam closed this as completed Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apurvam apurvam

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@miguno @IDispose @apurvam