Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properties file entries for maximum resiliency #817

Closed
blueedgenick opened this issue Feb 28, 2018 · 3 comments · Fixed by #3691
Closed

Properties file entries for maximum resiliency #817

blueedgenick opened this issue Feb 28, 2018 · 3 comments · Fixed by #3691
Assignees
@vinothchandar
Labels
documentation enhancement fix-it-week user-experience

Comments

@blueedgenick
Copy link
Contributor

blueedgenick commented Feb 28, 2018 •
edited by miguno
Loading

Recent enhancements to Kafka Streams API e.g KIP-224 have made it easier to configure a Streams application for maximum resiliency in the face of broker unavailability, such as that encountered during a rolling restart for example.

It seems desirable to collect all such best-practice settings and include them as defaults in the OOTB settings, or at the very least prominently document them.

For those users who prefer a 'fail-fast' approach, we can supply documentation of how to adjust the defaults to achieve this.
@rmoff
Copy link
Contributor

rmoff commented Jun 21, 2018

@blueedgenick does https://docs.confluent.io/current/ksql/docs/installation/server-config/config-reference.html#recommended-ksql-production-settings satisfy this issue?

@blueedgenick
Copy link
Contributor Author

Not really - the original request was to make it resilient OOTB, which it clearly isn't. I don't think hiding this away in the docs is necessarily the best solution we can provide....
Even if we don't want to make it resilient OOTB, we could easily provide a second properties file example in the distribution which did have those settings in it.

@rmoff
Copy link
Contributor

rmoff commented Jun 22, 2018

Gotcha - I mis-read the initial issue.
Do we have a list of these defaults that we'd want to set?

@blueedgenick blueedgenick mentioned this issue Oct 23, 2019
Closed
2 tasks
@vinothchandar vinothchandar self-assigned this Oct 23, 2019
vinothchandar added a commit to vinothchandar/ksql that referenced this issue Oct 29, 2019
@vinothchandar
fix: allow streams topic prefixed configs
4f76ab1 
Fixes confluentinc#817
- Adds new property file for production settings
- Changes to allow topic prefixed streams configs such as min.insync.replicas
- Unit tests added
- Verfied locally that the property file, creates topics with correct configuration
vinothchandar added a commit to vinothchandar/ksql that referenced this issue Oct 29, 2019
@vinothchandar
fix: allow streams topic prefixed configs
b8005df 
Fixes confluentinc#817
- Adds new property file for production settings
- Changes to allow topic prefixed streams configs such as min.insync.replicas
- Unit tests added
- Verfied locally that the property file, creates topics with correct configuration
@vinothchandar vinothchandar mentioned this issue Oct 29, 2019
Merged
2 tasks
vinothchandar added a commit to vinothchandar/ksql that referenced this issue Oct 29, 2019
@vinothchandar
fix: allow streams topic prefixed configs
b4a97be 
Fixes confluentinc#817
- Adds new property file for production settings
- Changes to allow topic prefixed streams configs such as min.insync.replicas
- Unit tests added
- Verfied locally that the property file, creates topics with correct configuration
vinothchandar added a commit to vinothchandar/ksql that referenced this issue Oct 29, 2019
@vinothchandar
fix: allow streams topic prefixed configs
e8c053d 
Fixes confluentinc#817
- Adds new property file for production settings
- Changes to allow topic prefixed streams configs such as min.insync.replicas
- Unit tests added
- Verfied locally that the property file, creates topics with correct configuration
vinothchandar added a commit to vinothchandar/ksql that referenced this issue Oct 29, 2019
@vinothchandar
fix: allow streams topic prefixed configs
81cb246 
Fixes confluentinc#817
- Adds new property file for production settings
- Changes to allow topic prefixed streams configs such as min.insync.replicas
- Unit tests added
- Verfied locally that the property file, creates topics with correct configuration
vinothchandar added a commit that referenced this issue Oct 29, 2019
@vinothchandar
fix: allow streams topic prefixed configs (#3691)
939c45a 
Fixes #817
- Adds new property file for production settings
- Changes to allow topic prefixed streams configs such as min.insync.replicas
- Unit tests added
- Verfied locally that the property file, creates topics with correct configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vinothchandar vinothchandar

Labels
documentation enhancement fix-it-week user-experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: allow streams topic prefixed configs vinothchandar/ksql
4 participants
@apurvam @vinothchandar @rmoff @blueedgenick