Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: Admin client leak #1301

Merged
merged 3 commits into from May 22, 2018
Merged

Minor: Admin client leak #1301

merged 3 commits into from May 22, 2018

Conversation

big-andy-coates
Copy link
Contributor

  • Fixes a leak of an AdminClient instance on the list topics; statement.
  • Fixes a resource leak in the CliTest
  • Fixes a load of code warnings, (in separate commit).

@big-andy-coates big-andy-coates requested a review from a team May 14, 2018 19:44
hjafarpour
hjafarpour approved these changes May 14, 2018
View reviewed changes
Copy link
Contributor

@hjafarpour hjafarpour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@big-andy-coates big-andy-coates requested a review from a team May 14, 2018 20:38
dguy
dguy approved these changes May 14, 2018
View reviewed changes
Copy link
Contributor

@dguy dguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

apurvam
apurvam approved these changes May 15, 2018
View reviewed changes
Copy link
Contributor

@apurvam apurvam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! How did you find the admin client leak? Just by reading?

@big-andy-coates
Copy link
Contributor Author

By debugging and seeing where they were being created and working backwards from there.

@big-andy-coates big-andy-coates merged commit 4ce9dce into confluentinc:master May 22, 2018
@big-andy-coates big-andy-coates deleted the admin_client_leak branch May 22, 2018 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dguy dguy dguy approved these changes

@apurvam apurvam apurvam approved these changes

@hjafarpour hjafarpour hjafarpour approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@big-andy-coates @dguy @apurvam @hjafarpour