Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consumed imports #1315

Merged
merged 1 commit into from May 17, 2018
Merged

Consumed imports #1315

merged 1 commit into from May 17, 2018

Conversation

guozhangwang
Copy link
Contributor

Description

This is for apache/kafka#5033

Testing done

Describe the testing stategy. Unit and integration tests are expected for any behavior changes.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@guozhangwang guozhangwang requested review from dguy and rodesai May 17, 2018 19:00
@guozhangwang
Copy link
Contributor Author

cc @confluentinc/ksql

dguy
dguy approved these changes May 17, 2018
View reviewed changes
Copy link
Contributor

@dguy dguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @guozhangwang, LGTM

apurvam
apurvam approved these changes May 17, 2018
View reviewed changes
Copy link
Contributor

@apurvam apurvam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@guozhangwang guozhangwang merged commit e2fa7b6 into confluentinc:master May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dguy dguy dguy approved these changes

@apurvam apurvam apurvam approved these changes

@rodesai rodesai Awaiting requested review from rodesai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@guozhangwang @dguy @apurvam