Avoid NPE if not function exists that handles required types. #1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… function don't match ones the function supports.
Current a statement such as `select concat('foo',1) from blah;` results in NPE:
`java.lang.NullPointerException`
With this change it results in:
`Function 'CONCAT' does not accept parameters of types:[VARCHAR(STRINT), BIGINT]`
2 tasks
|
Copied from other PR: Hey @hjafarpour - thanks for the review. I've switched the code to use SchemaUtil.TYPE_MAP, however I had to add a new method to access it, (please review!), and I've some questions about SchemaUtil here: #1399 (comment) |
big-andy-coates
requested review from
dguy,
hjafarpour and
apurvam
and removed request for
hjafarpour
dguy
approved these changes
Jun 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current a statement such as
select concat('foo',1) from blah;results in NPE:java.lang.NullPointerExceptionWith this change it results in:
Function 'CONCAT' does not accept parameters of types:[STRING, INT64]Replaces #1399 (Rebased onto 5.0 branch)
Testing done
Added unit test + manual testing.
Reviewer checklist